Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add assert/is-same-array-like-object #2894

Merged
merged 4 commits into from
Sep 15, 2024
Merged

feat: add assert/is-same-array-like-object #2894

merged 4 commits into from
Sep 15, 2024

Conversation

yaswanthkosuru
Copy link
Contributor

Resolves #2886.

Description

Add additonal package @stdlib/assert/is-same-array-like-object to check same array like objects.

This pull request:

Other

This Package is just same as is-same-array-like but it checks if objects also match or not .
ex:"bee",["b","e","e"] doesnt match.
i only find above one difference and wrote code according to these.

Checklist

  • Read, understood, and followed the contributing guidelines.
  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.

@stdlib-js/reviewers

@yaswanthkosuru
Copy link
Contributor Author

@Planeshifter Ready for initial Review

Planeshifter
Planeshifter approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Looks great; made only a small change and will merge shortly.

lib/node_modules/@stdlib/assert/is-same-array-like-object/examples/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/assert/is-same-array-like-object/test/test.js Show resolved Hide resolved
@Planeshifter
chore: apply suggestions from code review
e1a4756 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: resolve lint errors
c661739 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: remove trailing spaces
b725661 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit 15e6c71 into stdlib-js:develop Sep 15, 2024
10 checks passed
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add assert/is-same-array-like-object
3 participants
@yaswanthkosuru @Planeshifter @kgryte