Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @stdlib/fs/resolve-parent-paths-by #2897

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

gururaj1512
Copy link

@gururaj1512 gururaj1512 commented Sep 12, 2024

Resolves #2567.

Description

What is the purpose of this pull request?
Adds JS implementation for @stdlib/fs/resolve-parent-paths-by/

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@gururaj1512 gururaj1512 changed the title resolve-parent-paths-by feat: add @stdlib/fs/resolve-parent-paths-by Sep 12, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Sep 16, 2024
@gururaj1512
Copy link
Author

hey @kgryte, can you explain this linting error in README file at line 3.
Screenshot 2024-09-16 165059

@Snehil-Shah
Copy link
Member

@gururaj1512 is this when you try to commit?

@gururaj1512
Copy link
Author

@Snehil-Shah that error occurs when commiting and also while running eslint

@Snehil-Shah
Copy link
Member

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean).
Also, can you show the full error and what exactly are/were you trying to commit?


If a `predicate` function calls the `next` callback with a `truthy` second argument, the function proceeds to next function and returns the resolved path.

If unable to resolve a path, the function returns `null` as the path result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function doesn't return null, either an empty array or Array<null> in case of each mode. I would suggest being specific and moving this to the ## Notes section. I'll update resolve-parent-paths accordingly too.

cc: @kgryte

@gururaj1512
Copy link
Author

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean). Also, can you show the full error and what exactly are/were you trying to commit?

Yaa, I have tried make clean & make install
Lint Error
This error occurs while running command npx eslint path/to/directory/

@Snehil-Shah
Copy link
Member

@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? (make install, make init). Maybe try clean installing and setting up again (after make clean). Also, can you show the full error and what exactly are/were you trying to commit?

Yaa, I have tried make clean & make install Lint Error This error occurs while running command npx eslint path/to/directory/

Ok, was able to reproduce it. Seems to me, it's something specific to npx as I am able to commit the file without any errors. And in any case, you don't need to run npx eslint manually, the linter is automatically triggered before every commit via git hooks (assuming your environment is set up as expected). If you still wish to manually trigger the linter, you can use the make recipes (like make lint) listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/fs/resolve-parent-paths-by
3 participants