-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @stdlib/fs/resolve-parent-paths-by
#2897
base: develop
Are you sure you want to change the base?
feat: add @stdlib/fs/resolve-parent-paths-by
#2897
Conversation
@stdlib/fs/resolve-parent-paths-by
hey @kgryte, can you explain this linting error in |
@gururaj1512 is this when you try to commit? |
@Snehil-Shah that error occurs when commiting and also while running |
@gururaj1512 Weird. I can't seem to reproduce the error. Did you follow the setup guide properly? ( |
|
||
If a `predicate` function calls the `next` callback with a `truthy` second argument, the function proceeds to next function and returns the resolved path. | ||
|
||
If unable to resolve a path, the function returns `null` as the path result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function doesn't return null
, either an empty array or Array<null>
in case of each
mode. I would suggest being specific and moving this to the ## Notes
section. I'll update resolve-parent-paths
accordingly too.
cc: @kgryte
lib/node_modules/@stdlib/fs/resolve-parent-paths-by/lib/index.js
Outdated
Show resolved
Hide resolved
Yaa, I have tried |
Co-authored-by: Snehil Shah <[email protected]> Signed-off-by: Gururaj Gurram <[email protected]>
Ok, was able to reproduce it. Seems to me, it's something specific to npx as I am able to commit the file without any errors. And in any case, you don't need to run |
Resolves #2567.
Description
This pull request:
@stdlib/fs/resolve-parent-paths-by
#2567Related Issues
This pull request:
@stdlib/fs/resolve-parent-paths-by
#2567Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers