Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update scaffolding for creating unary math iterator packages #2927

Merged
merged 27 commits into from
Oct 4, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@gunjjoshi gunjjoshi marked this pull request as draft September 20, 2024 18:43
@gunjjoshi
Copy link
Member Author

While running this, I get the following error:

Screenshot 2024-09-21 at 00 16 34

@gunjjoshi
Copy link
Member Author

I thought to update scaffold.sh once we have a basic working script.

Along with that, are we also thinking to update our scaffolding structure (https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/_tools/scaffold/math-iter-unary/data), as our meta data does not contain some of the fields used in that.

@gunjjoshi
Copy link
Member Author

What are we using this for: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/_tools/scaffold/math-iter-unary/scripts/data.json#L3 ?
With this included, I get the error:

/bin/sh: =math/[email protected]: No such file or directory

When I remove this from data.json, it works, and the packages are being made at the required path.

@gunjjoshi
Copy link
Member Author

Made a few changes, the structure is generated correctly now.

@gunjjoshi gunjjoshi marked this pull request as ready for review September 29, 2024 04:24
@kgryte kgryte added Math Issue or pull request specific to math functionality. Tools Issue or pull request related to project tooling. labels Oct 4, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I think this is now ready for merge. I made a number of changes, @gunjjoshi. In preparation for other scaffolding tools (which will get more complex!), probably worthwhile studying the changes and reverse engineering why I made the ones that I did.

Some things won't be obvious (e.g., replacing backticks in require paths in index.d.ts files => historical artifact due to prior tooling limitation), while others rely a bit more on understanding that there will be exceptions we'll need to account for (e.g., relying on DESC to provide a default description will work for many cases, but there will be other packages in which we cannot do this and need to be more particular about specifying PKG_DESC, MODULE_DESC, etc).

@kgryte kgryte merged commit a9cd099 into stdlib-js:develop Oct 4, 2024
22 checks passed
@kgryte kgryte changed the title chore: add runner script to create packages in math/iter/special build: update scaffolding for creating unary math iterator packages Oct 4, 2024
@gunjjoshi
Copy link
Member Author

Thanks for making these changes, @kgryte. I'll go through them once so that we follow the latest conventions in future packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Tools Issue or pull request related to project tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants