-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update scaffolding for creating unary math iterator packages #2927
Conversation
I thought to update Along with that, are we also thinking to update our scaffolding structure (https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/_tools/scaffold/math-iter-unary/data), as our meta data does not contain some of the fields used in that. |
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/runner.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/runner.js
Show resolved
Hide resolved
What are we using this for: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/_tools/scaffold/math-iter-unary/scripts/data.json#L3 ?
When I remove this from |
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/runner.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <[email protected]>
Made a few changes, the structure is generated correctly now. |
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/runner.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
…ts/runner.js Co-authored-by: Athan <[email protected]> Signed-off-by: Gunj Joshi <[email protected]>
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/_tools/scaffold/math-iter-unary/scripts/scaffold.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I think this is now ready for merge. I made a number of changes, @gunjjoshi. In preparation for other scaffolding tools (which will get more complex!), probably worthwhile studying the changes and reverse engineering why I made the ones that I did.
Some things won't be obvious (e.g., replacing backticks in require
paths in index.d.ts
files => historical artifact due to prior tooling limitation), while others rely a bit more on understanding that there will be exceptions we'll need to account for (e.g., relying on DESC
to provide a default description will work for many cases, but there will be other packages in which we cannot do this and need to be more particular about specifying PKG_DESC
, MODULE_DESC
, etc).
math/iter/special
Thanks for making these changes, @kgryte. I'll go through them once so that we follow the latest conventions in future packages. |
Description
This pull request:
runner.js
in_tools/scaffold/math-iter-unary/scripts
to generate packages inmath/iter/special
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers