Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: achieve 100% test coverage for blas/ext/base/dnansumkbn #3051

Merged
merged 1 commit into from
Nov 9, 2024
Merged

test: achieve 100% test coverage for blas/ext/base/dnansumkbn #3051

merged 1 commit into from
Nov 9, 2024

Conversation

headlessNode
Copy link
Contributor

Resolves #3046 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds a test case to achieve 100% test coverage for blas/ext/base/dnansumkbn

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
Copy link
Contributor Author

The failing test is from dnansum which uses dnansumkbn to compute the sum. This will be fixed when dnansum is refactored.

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 1, 2024
This was referenced Nov 8, 2024
Open
Open
Closed
Planeshifter
Planeshifter approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @headlessNode!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 9, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

test: achieve 100% test coverage for `blas/ext/base/dnansumkbn`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3051
Closes: https://github.com/stdlib-js/stdlib/issues/3046

Co-authored-by: 
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit cc6362b into stdlib-js:develop Nov 9, 2024
22 of 23 checks passed
@Planeshifter Planeshifter mentioned this pull request Nov 9, 2024
Closed
1 task
@headlessNode headlessNode deleted the dnansumkbn-test branch November 10, 2024 04:16
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@headlessNode @aayush0325
test: achieve 100% test coverage for blas/ext/base/dnansumkbn
9c570f3 
PR-URL: stdlib-js#3051
Closes: stdlib-js#3046

Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete code coverage for blas/ext/base/dnansumkbn
3 participants
@headlessNode @stdlib-bot @Planeshifter