Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stats/base/dists/kumaraswamy/variance #4495

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

ShabiShett07
Copy link

Resolves #3707

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 3, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/kumaraswamy/variance $\color{green}200/200$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}200/200$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
Copy link
Author

/stdlib check-files - Check for required files.

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot
Copy link
Contributor

@ShabiShett07, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@ShabiShett07
Copy link
Author

/stdlib check-files

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 3, 2025
@ShabiShett07
Copy link
Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@ShabiShett07
Copy link
Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@ShabiShett07 ShabiShett07 changed the title feat: add @stdlib/stats/base/dists/kumaraswamy/variance feat: add stats/base/dists/kumaraswamy/variance Jan 6, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Left a bunch of comments that will have to be addressed before we can proceed with merging it.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 19, 2025
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Author

Thank you for reviewing my PR @Planeshifter sir, I have made all the necessary changes you have mentioned here and I am working on fixtures related to the variance.

@ShabiShett07 ShabiShett07 force-pushed the feature/kumaraswamy/variance branch from d27c12a to 7c1a265 Compare January 21, 2025 13:36
@ShabiShett07
Copy link
Author

Hello, @Planeshifter sir, I have successfully added fixtures as per your suggestions. Please do check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/kumaraswamy/variance
3 participants