Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python packaging #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

phodina
Copy link

@phodina phodina commented Jul 27, 2023

Hi,
thanks for developing these tools further.

Here's just some glue around the Python code to package it for distros. I'm packaging it for GNU Guix OS.

Copy link
Owner

@steadfasterX steadfasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole movement from libexec -> src requires to update SALT first:

https://github.com/steadfasterX/SALT/blob/master/kdzmanager.sh

until this is not done we cannot do that change here. dunno if you wanna take that part as well but this repo does exist only for the reason bc I use it in SALT..
if you can do the changes there as well I would be happy to merge this here though.

@@ -1,4 +1,4 @@
#!/usr/bin/env python2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem here is that we have different distro's out there and the time where this code was written python2 was default - now it is python3 on all modern ones but we cannot be sure. the code has been adapted to python3 a while ago so we can force python3 here imo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

readme="README.txt"
classifiers = [
"Programming Language :: Python :: 3",
"License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indent level? ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I copied the latter so that's probably the reason.

@@ -1,4 +1,4 @@
#!/usr/bin/env python3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem here is that we have different distro's out there and the time where this code was written python2 was default - now it is python3 on all modern ones but we cannot be sure. the code has been adapted to python3 a while ago so we can force python3 here imo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@phodina
Copy link
Author

phodina commented Aug 7, 2023

the whole movement from libexec -> src requires to update SALT first:

https://github.com/steadfasterX/SALT/blob/master/kdzmanager.sh

until this is not done we cannot do that change here. dunno if you wanna take that part as well but this repo does exist only for the reason bc I use it in SALT.. if you can do the changes there as well I would be happy to merge this here though.

Okay, I'll check SALT and make the modifications. The reason why I'm making this PR is that I'd like to have the SALT tool packaged and it depends on the 2 Python subpackages which need some packaging mechanism - pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants