-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packaging #9
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole movement from libexec -> src
requires to update SALT first:
https://github.com/steadfasterX/SALT/blob/master/kdzmanager.sh
until this is not done we cannot do that change here. dunno if you wanna take that part as well but this repo does exist only for the reason bc I use it in SALT..
if you can do the changes there as well I would be happy to merge this here though.
@@ -1,4 +1,4 @@ | |||
#!/usr/bin/env python2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem here is that we have different distro's out there and the time where this code was written python2 was default - now it is python3 on all modern ones but we cannot be sure. the code has been adapted to python3 a while ago so we can force python3 here imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
readme="README.txt" | ||
classifiers = [ | ||
"Programming Language :: Python :: 3", | ||
"License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indent level? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I copied the latter so that's probably the reason.
@@ -1,4 +1,4 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem here is that we have different distro's out there and the time where this code was written python2 was default - now it is python3 on all modern ones but we cannot be sure. the code has been adapted to python3 a while ago so we can force python3 here imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood
Okay, I'll check SALT and make the modifications. The reason why I'm making this PR is that I'd like to have the SALT tool packaged and it depends on the 2 Python subpackages which need some packaging mechanism - |
Hi,
thanks for developing these tools further.
Here's just some glue around the Python code to package it for distros. I'm packaging it for GNU Guix OS.