Tilde extension to allow replacing plugin modules #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the tilde extension `src/system-extension-tilde.js` which makes it easy for plugins to define places that can be replaced by `normalized` and `located` modules. The idea is that a plugin can identify a regular expression (or an array of regular expressions) which will be used to replace moduleNames located in those regular expressions with a full address which has been found by running the module name through normalize and locate hook. This applies replacements for less and css as outlined in issue #277
| @@ -70,6 +70,6 @@ function isProduction(){ | |||
| return (loader.isEnv && loader.isEnv("production")) || | |||
| loader.env === "production"; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
didn't you take this option away?
|
I'm wonder if this should be a configDependency rather than in core. I'm not sure about adding 120LOC for such a specific use-case, seems like it would make a nice configDep. |
|
What would be even nicer is if we had a proper extension system as described in #414 and the StealJS roadmap, that way this could be pushed to NPM. But unfortunately for now moving this into |
|
This is currently merged into minor (along with progressive package.jsons) so if you need to do any more prerelease let me know. |
|
to be clear, this PR is replaced by #605 ? |
|
That's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the tilde extension
src/system-extension-tilde.jswhich makes it easy for plugins to define places that can be replaced bynormalizedandlocatedmodules. The idea is that a plugin can identify a regular expression (or an array of regular expressions) which will be used to replace moduleNames located in those regular expressions with a full address which has been found by running the module name through normalize and locate hook.This applies replacements for less and css as outlined in issue #277