Fix S3 filenames that include a hash #121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when we switched to using Zip Stream recently, S3 filenames with a hash
#
were being truncated. The LaravelStorage
facade handles hashes without issue.Possible breaking changes I can think of with this PR:
strlen("s3://{$this->getBucket()}/");
means that if anyone has a malformed S3 bucket string, this would fail in unexpected waysparse_url()
, this does change how S3 file paths are parsed