Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance storage wrapper #1017

Merged
merged 11 commits into from
Jun 24, 2023
Merged

Add instance storage wrapper #1017

merged 11 commits into from
Jun 24, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jun 24, 2023

What

Add instance storage wrapper

Why

Instance storage is introduced in host to make it cheaper to store data bound to the contract instance.

Known limitations

N/A

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple doc comments. Otherwise lgtm.

soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
soroban-sdk/src/storage.rs Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member

Seems to have a compile error.

@dmkozh
Copy link
Contributor Author

dmkozh commented Jun 24, 2023

Seems to have a compile error.

Oh, sure, this is blocked by env pr stellar/rs-soroban-env#886

@graydon graydon enabled auto-merge (squash) June 24, 2023 05:52
@graydon graydon merged commit 71a3bea into stellar:main Jun 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants