Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map iterator to be index based #1061

Merged
merged 5 commits into from
Aug 19, 2023
Merged

Update map iterator to be index based #1061

merged 5 commits into from
Aug 19, 2023

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Aug 18, 2023

What

Sdk part of stellar/rs-soroban-env#992

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change front_pos and back_pos to pos and len, but otherwise looks good!

@jayz22 jayz22 marked this pull request as ready for review August 18, 2023 22:05
@graydon graydon merged commit da987a9 into stellar:main Aug 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants