Use ConstructorArgs trait for args on deploy with constructor #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use ConstructorArgs trait for args on deploy with constructor, and rename deploy with constructor to deploy_v2.
Why
So that types can be passed directly to the deploy function like they can now be passed to the register function since #1343.
I renamed the function to deploy_v2 for consistency with what we did when we added a second register for stellar asset contract function. I considered merging with the deploy function which would have been a breaking change, that I think we agreed would be worthwhile, but breaking is just such a bad experience and I think a _v2 is almost as good. We can consider merging the deploy functions at a later date.
Close #1347