Add compile errors when built with unsupported wasm features #1353
Conversation
|
I tested this on However, when I tested with Before we merge this it would be ideal to confirm why these features are not enabled on 1.82-beta. I've started a coversation in Zulip to find out more: |
|
Got feedback on https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/wasm32.20reference-types.20.2F.20multivalue.20in.201.2E82-beta.20not.20enabled/near/473794770 that indicated that the cfg guards for target features won't work on beta because they're still marked as unstable. But the fact they work on nightly is a good signal that the change is good to go. We can merge this and release it, and backport it to the previous release too. |
### What Add compile errors when built with unsupported wasm features reference-types and multivalue. ### Why Rust 1.82 is likely to ship with target feature reference-types and multivalue enabled on wasm builds. These target features are not supported by the Soroban Env in the current protocol 21 or next planned protocol 22. It's not trivial for developers to disable target features because of how the rustc compiler only exposes the ability to buildstd with nightly. These compile errors will prevent someone from building .wasm files with the sdk when either of those target features are enabled. A Rust version check is not being done because it's actually easier to do a target feature check, and in the off chain somehow Rust 1.82 shipped without the target features enabled then the sdk could still be used with 1.82. Links: - https://discord.com/channels/897514728459468821/1289090985569026048 - stellar/rs-soroban-env#1469 - WebAssembly/tool-conventions#233 ### Releasing This change will be merged to `main` targeting v22, then should be backported to a v21 patch release immediately following. (cherry picked from commit 6c45fb9)
What
Add compile errors when built with unsupported wasm features reference-types and multivalue.
Why
Rust 1.82 is likely to ship with target feature reference-types and multivalue enabled on wasm builds. These target features are not supported by the Soroban Env in the current protocol 21 or next planned protocol 22. It's not trivial for developers to disable target features because of how the rustc compiler only exposes the ability to buildstd with nightly.
These compile errors will prevent someone from building .wasm files with the sdk when either of those target features are enabled.
A Rust version check is not being done because it's actually easier to do a target feature check, and in the off chain somehow Rust 1.82 shipped without the target features enabled then the sdk could still be used with 1.82.
Links:
reference-typesby default WebAssembly/tool-conventions#233Releasing
This change will be merged to
maintargeting v22, then should be backported to a v21 patch release immediately following.