Add auth interface #952
Merged
Add auth interface #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
May 18, 2023
dmkozh
reviewed
May 18, 2023
|
I'm going to hold this change and do more experimentation with it. |
leighmcculloch
added a commit
that referenced
this pull request
May 18, 2023
dmkozh
approved these changes
May 18, 2023
|
Holding this because it's near impossible to use multiple contractimpls now. It has always been tricky, but seems like it has gotten worse. Using this is really dependent on #268. |
Merged
graydon
pushed a commit
that referenced
this pull request
Jun 23, 2023
### What Add `#[contract]` macro that generates a contract client for the contract, and make #[contractimpl] only add functions to the existing contract client. ### Why To support multiple `#[contractimpl]` per contract. For contracts that have multiple impls, it is not ideal if there are multiple clients for that one contract. Ideally clients appear in the same way everywhere, and anyone importing the contract will see a single flat client. Since macros cannot coordinate, there's no way for the first contractimpl to output the client struct and others to skip it. Today what happens is a compile error is shown because there are multiple clients generated. Unblocks: - #952 - #965 - And general better interoperability through trait sharing. Close #268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add auth interface.
Why
So that contracts who wish to implement the
__check_authfunction to provide custom auth can do so by implementing a trait, which is more convenient than copy-pasting a specific function.The reason we left this out previously was because it is not convenient for developers to implement multiple traits. However, there is a work around for this, and the work around is more convenient than getting the function right.