build: fork, don't patch, open-rpc-docs-react #860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working toward stellar#404 We were essentially forking `@metamask/open-rpc-docs-react` already, but in a more brittle way using `"post-install": "patch-package"` and a `.patch` file that applied a patch directly to the built artifacts from the library. I've now created an actual fork at https://github.com/AhaLabs/open-rpc-docs-react Which is published at https://www.npmjs.com/package/@ahalabs/open-rpc-docs-react I'd like to move this to `@stellar/open-rpc-docs-react` in both GitHub and NPM, but demonstrates that it will work, at least.
|
Preview is available here: |
|
I think we should move this to |
3 tasks
|
Closing in favor of #1053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working toward #404
We were essentially forking
@metamask/open-rpc-docs-reactalready, but in a more brittle way using"post-install": "patch-package"and a.patchfile that applied a patch directly to the built artifacts from the library.I've now created an actual fork at https://github.com/AhaLabs/open-rpc-docs-react Which is published at https://www.npmjs.com/package/@ahalabs/open-rpc-docs-react
I'd like to move this to
@stellar/open-rpc-docs-reactin both GitHub and NPM, but this demonstrates that it will work, at least.