Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit/KAD-3783 #636

Merged
merged 5 commits into from
Jan 6, 2025
Merged

audit/KAD-3783 #636

merged 5 commits into from
Jan 6, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3783
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

On the PHP file, I replaced ( isset($media_icon['unit']) ? $media_icon['unit'] : 'px') with a variable.

For the icon size, I removed the changes to the gen-icon file and applied the size in the backend via the parent div's font size. I found that the single buttons use the font size to set the icon size too. The info box icon now uses the font-size in the backend just like in the frontend.

@gilbert-hernandez
Copy link
Contributor Author

@oakesjosh

reduced several conditionals to variables for reuse as we discussed.

@oakesjosh oakesjosh merged commit 5ca55b8 into master Jan 6, 2025
25 checks passed
@oakesjosh oakesjosh deleted the audit/KAD-3783 branch January 6, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants