Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KAD-3933 #637

Merged
merged 2 commits into from
Jan 8, 2025
Merged

bugfix/KAD-3933 #637

merged 2 commits into from
Jan 8, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3933
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

gilbert-hernandez commented Dec 31, 2024

Is the placement of the new code ok? The problem is that the render_row_gap_property() function doesn't return the correct value when the tabletGutter and mobileGutter attributes are empty but columnGutter isn't. Ideally, the tablet and mobile gutters should inherit, but the render_row_gap_property() function returns a different result. This fix adds tabletGutter mobileGutter if columnGutter is available.

I decided to update the row layout block instead of updating the render_row_gap_property() function to accommodate the scenario.

@gilbert-hernandez
Copy link
Contributor Author

@oakesjosh

Moved the fix to the CSS class function as we discussed. Also, made some updates as the previous fix didn't consider custom gap values.

@oakesjosh oakesjosh merged commit 3008486 into master Jan 8, 2025
25 checks passed
@oakesjosh oakesjosh deleted the bugfix/KAD-3933 branch January 8, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants