fix #533 (#534)

stelligent · Mar 26, 2021 · ab8f0fe · ab8f0fe
1 parent 8567d6d
commit ab8f0fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/cfn-nag/custom_rules/ECRRepositoryScanOnPushRule.rb b/lib/cfn-nag/custom_rules/ECRRepositoryScanOnPushRule.rb
@@ -6,7 +6,7 @@
 
 class ECRRepositoryScanOnPushRule < BaseRule
   def rule_text
-    'ECR Repository should have scanOnPush enabled'
+    'ECR Repository should have ScanOnPush enabled'
   end
 
   def rule_type
@@ -20,7 +20,7 @@ def rule_id
   def audit_impl(cfn_model)
     violating_ecr_registries = cfn_model.resources_by_type('AWS::ECR::Repository').select do |registry|
       registry.imageScanningConfiguration.nil? ||
-        !truthy?(registry.imageScanningConfiguration['scanOnPush'].to_s)
+        !truthy?(registry.imageScanningConfiguration['ScanOnPush'].to_s)
     end
 
     violating_ecr_registries.map(&:logical_resource_id)

diff --git a/spec/test_templates/yaml/ecrregistry/registries_with_no_scanonpush_enabled.yaml b/spec/test_templates/yaml/ecrregistry/registries_with_no_scanonpush_enabled.yaml
@@ -5,7 +5,7 @@ Resources:
     Properties: 
       RepositoryName: "test-repository"
       ImageScanningConfiguration: 
-        scanOnPush: "false"
+        ScanOnPush: "false"
   MyRepositoryWithNoConfigDefault: 
     Type: AWS::ECR::Repository
     Properties: 

diff --git a/spec/test_templates/yaml/ecrregistry/registries_with_scanonpush_enabled.yaml b/spec/test_templates/yaml/ecrregistry/registries_with_scanonpush_enabled.yaml
@@ -5,4 +5,4 @@ Resources:
     Properties: 
       RepositoryName: "test-repository"
       ImageScanningConfiguration: 
-        scanOnPush: "true"
+        ScanOnPush: "true"