Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to cfn-model 0.6.9 #599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arothian
Copy link
Contributor

@arothian arothian commented Jun 7, 2022

No description provided.

@arothian arothian changed the title chore: Update to cfn-model 0.6.8 chore: Update to cfn-model 0.6.9 Jun 23, 2022
@orien
Copy link

orien commented Jul 16, 2022

We should be able to get a passing CI build once Rubygems is upgraded to latest:

--- a/.github/workflows/tests-linting.yml
+++ b/.github/workflows/tests-linting.yml
@@ -28,6 +28,7 @@ jobs:
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
+        rubygems: latest
         bundler-cache: true
     - name: Rubocop lint
       run: bundle exec rubocop -D
@@ -51,5 +52,6 @@ jobs:
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
+        rubygems: latest
     - name: e2e
       run: bash ./scripts/setup_and_run_end_to_end_tests.sh

There seems to be an incompatibility with older versions of Rubygems and psych version 4.

@orien
Copy link

orien commented Nov 24, 2022

Hi @arothian, is there anything I can help with to get this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants