This version can change Serial by user. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't .begin() if baudrate is negative
stephane
approved these changes
Nov 24, 2020
stephane
requested changes
Nov 24, 2020
stephane
reviewed
Nov 24, 2020
| @@ -230,9 +231,10 @@ static int receive(uint8_t *req, uint8_t _slave) | |||
| } | |||
|
|
|||
|
|
|||
| static void reply(uint16_t *tab_reg, uint16_t nb_reg, uint8_t *req, | |||
| uint8_t req_length, uint8_t _slave) | |||
| static uint32_t reply(uint16_t *tab_reg, uint16_t nb_reg, uint8_t *req, | |||
There was a problem hiding this comment.
This change about return of reply should be in another PR
stephane
requested changes
Nov 24, 2020
| { | ||
| uint32_t backnum = 0; |
There was a problem hiding this comment.
I don't find the backnum term explicit.
| @@ -297,5 +306,11 @@ int ModbusinoSlave::loop(uint16_t *tab_reg, uint16_t nb_reg) | |||
| -1 if an undefined error has occured, | |||
| -2 for MODBUS_EXCEPTION_ILLEGAL_FUNCTION | |||
| etc */ | |||
| return rc; | |||
| // if(rc > 0) { | |||
| @@ -30,11 +30,12 @@ | |||
|
|
|||
| class ModbusinoSlave { | |||
| public: | |||
| ModbusinoSlave(uint8_t slave); | |||
| void setup(long baud); | |||
| ModbusinoSlave(); | |||
|
|
||
| 1. Check for open issues or open a fresh issue to start a discussion around a feature idea or a bug. |
There was a problem hiding this comment.
Removing of information about contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version can change Serial by user. And update the examples.