Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SpecifiedLineTradeDelivery/ChargeFreeQuantity and PackageQuantity for ZUGFeRD Extended Profile #601

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PeterSawatzki-MGGM
Copy link
Contributor

add SpecifiedLineTradeDelivery/ChargeFreeQuantity and PackageQuantity for ZUGFeRD Extended Profile

@stephanstapel
Copy link
Owner

Thanks for your change. Can you please add tests?

add params to AddTradeLineItem to prepare for ChargeFreeQuantity and PackageQuantity testing
@PeterSawatzki-MGGM
Copy link
Contributor Author

Could you give me a hint where to add the test for ChargeFreeQuantity and PackageQuantity? I prepared for testing by adding four parameters ChargeFreeQuantity, ChargeFreeUnitCode, PackageQuantity and PackageUnitcode to AddTradeLineItem. Should the testing be added to one of the existing test procedures or should a new one be added ?

@stephanstapel
Copy link
Owner

Could you give me a hint where to add the test for ChargeFreeQuantity and PackageQuantity? I prepared for testing by adding four parameters ChargeFreeQuantity, ChargeFreeUnitCode, PackageQuantity and PackageUnitcode to AddTradeLineItem. Should the testing be added to one of the existing test procedures or should a new one be added ?

please add specific tests for the new functionality.
Concerning the functionality you added: instead of adding the parameters to AddTradeLineItem(), could you create functions called SetChargeFreeQuantity() And SetPackageQuantityt() to the TradeLineItem class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants