Add a check to see if the node server is down or not #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will check if the server is still up or not. If it's down for some reason, it will reset the pid, and that will allow grinder to restart the server. If the server doesn't restart, the fuzzer will still keep going (without any testcases), and that is bad.
|
Ok cool, no problem. Thanks. |
|
so i have tested this fix for the last 2~3 months on my nodes and it is working great, i no longer see dead server please merger this PR. |
stephenfewer
added a commit
that referenced
this pull request
May 12, 2015
Add a check to see if the node server is down or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #40 (Node server shuts down and cannot restart). I haven't got a chance to actually look into why the node server goes down in some cases, but I feel it is definitely necessary for grinder to be able to restart the node server as long as the debugger is alive. If not, the debugging will just keep respawning the browser without any testcases.
Please note that I am not 100% familiar with grinder, so I'm not super confident if this implementation is appropriate or not. If you don't like it, please feel free to close.