-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any consistency guarantee between CS and joint PIP #203
Comments
The SuSiE variational approximation assumes independence of the single effects. This assumption can be violated of course, so there is no consistency guarantee. Perhaps exploring this more could lead to an interesting research direction. |
I tried to compute joint PIP with marginal PIPs but I realized some variants has PIP zero. For instance, the Joint PIP that the variant is in the middle third:
gives zero. So would it be fair to claim that the credible sets SusieR chooses are of very small probabilities? |
Also wondering if this calculation is correct. Shall I be summing or multiplying PIPs to get joint PIP? |
It says in the paper: "Arguably, this is exactly the kind of posterior summary that we would like to obtain from Markov chain Monte Carlo based or stochastic search BVSR methods, but doing so would require non-trivial post-processing of their output. In contrast, our method provides this posterior summary directly, and with little extra computational effort."
Is there any consistency guarantee between CS and joint PIP? That is, if I create an algorithm that enumerate and search all subsets whose
sum ofjoint PIP is greater or equal to some coverage, will it lead me to the same CS generated by SusieR?The text was updated successfully, but these errors were encountered: