Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bookmarklet to support iframes in shadow dom #101

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

nonmetalhail
Copy link

I found that the bookmarklet doesnt work when an iframe is located inside a shadow DOM because the code only looks for iframes that are part of the base document, not inside the shadow roots. This PR changes the code to also search for iframe elements in all shadowRoots and apply the style element to them.

Unminified bookmarklet:

javascript:(function(){
  var d=document,
      id='phltsbkmklt',
      el=d.getElementById(id),
      f=d.querySelectorAll('iframe'),
      i=0;
  
  if(el){
    function removeFromShadows(root){
      for(var el of root.querySelectorAll('*')){
        if(el.shadowRoot){
          el.shadowRoot.getElementById(id).remove();
          const frames = el.shadowRoot.querySelectorAll('iframe');
          removeFromIFrames(frames);
          removeFromShadows(el.shadowRoot);
        }
      }
    }
    function removeFromIFrames(frames) {
      for(i=0;i<frames.length;i++){
        try{
          frames[i].contentWindow.document.getElementById(id).remove();
          removeFromShadows(frames[i].contentWindow.document);
        }catch(e){
          console.log(e)
        }
      }
    }
    el.remove();
    removeFromIFrames(f);
    removeFromShadows(d);
  }else{
    s=d.createElement('style');
    s.id=id;
    s.appendChild(d.createTextNode('*{line-height:1.5 !important;letter-spacing:0.12em !important;word-spacing:0.16em !important;}p{margin-bottom:2em !important;}'));
    
    function applyToShadows(root){
      for(var el of root.querySelectorAll('*')){
        if(el.shadowRoot){
          el.shadowRoot.appendChild(s.cloneNode(true));
          const frames = el.shadowRoot.querySelectorAll('iframe');
          applyToIFrames(frames);
          applyToShadows(el.shadowRoot);
        }
      }
    }
    function applyToIFrames(frames) {
      for(i=0;i<frames.length;i++){
        try{
          frames[i].contentWindow.document.getElementsByTagName('head')[0].appendChild(s.cloneNode(true));
          applyToShadows(frames[i].contentWindow.document);
        }catch(e){
          console.log(e)
        }
      }
    }
    d.getElementsByTagName('head')[0].appendChild(s);
    applyToIFrames(f);
    applyToShadows(d);
  }
})();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant