Harre/net48 support and sample #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartmark
force-pushed
the
harre/net48-support-and-sample
branch
from
2813467 to
f59eb51
Compare
Also updated .net 3.1 samples to .net 6 as it is EOL Only change to CorrelationId project is a minor nuget bump
hartmark
force-pushed
the
harre/net48-support-and-sample
branch
from
f59eb51 to
7be4f3f
Compare
Request header is now set if a new is autogenerated Fixed the samples with nested HttpClients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library targets .net standard 2.0 so it can be used in a .net framework 4.8 project.
However if doing so you need to add your own middleware to get the headers properly set.
I have added a sample test-project that uses .net 4.8 and is wrapping CorrelationIdMiddleware as a HttpMessageHandler so we can utilize the functionality of this library.