-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added in CH_andrew #71
Open
projectPythonator
wants to merge
14
commits into
stevenhalim:master
Choose a base branch
from
projectPythonator:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 29, 2020
-
AGIS DANIELS EDITS I made this compressed version of the code from c++ and a python version on wikibooks toVec was moved to sub as toVec(a,b)== b-a tested this on 2 kattis problems my own version works on tested on 4 problems but it requires area and perimeter to work ccw and cross are almost the same in python as in c++ i added in a few things into the point class for it to solve the two convex hull problems on kattis that i tested on
projectPythonator authoredJul 29, 2020 Configuration menu - View commit details
-
Copy full SHA for 74eec1f - Browse repository at this point
Copy the full SHA 74eec1fView commit details
Commits on Jul 30, 2020
-
Agis Daniels for consistency reasons i removed sub and re added vec ccw already used it in a difference file so i just used it from the points line .py as well < had a more elegant version from that file too so i used it here too retested and still holds ac on kattis
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 3155940 - Browse repository at this point
Copy the full SHA 3155940View commit details -
Agis Daniels nice one liner for area i called cross product function to avoid the need to retype the code again should help avoid typos when implementing it from paper the less than for point seems to work nicely with floats :) also added a oneliner version of the perimeter function above the code as well
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for fc12bae - Browse repository at this point
Copy the full SHA fc12baeView commit details -
Merge pull request #1 from projectPythonator/AgisDaniels
Agis daniels
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 8aab900 - Browse repository at this point
Copy the full SHA 8aab900View commit details -
Agis Daniels they already existed in other files polyline.py is where i took these ones from also why is origin needed in the alt version of polygon area ??
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for e340872 - Browse repository at this point
Copy the full SHA e340872View commit details -
Agis Daniels already existed in pointlines file so i just used the one from there
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for f3c5849 - Browse repository at this point
Copy the full SHA f3c5849View commit details -
Agis Daniels the code i use in my own implementation is similar so i can just swap out my call with ccw as its similar to the c++ code :)
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 35386a9 - Browse repository at this point
Copy the full SHA 35386a9View commit details -
Agis Daniels im a bit iffy on insidePolygon as i tried to implment it before both like this and super mega compressed version and it had some errors for some reason the second loop had errors i mean will need to ask suhendry about it
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 989a01f - Browse repository at this point
Copy the full SHA 989a01fView commit details -
Merge pull request #2 from projectPythonator/AgisDaniels
Agis daniels good to go
projectPythonator authoredJul 30, 2020 Configuration menu - View commit details
-
Copy full SHA for 74ac3a5 - Browse repository at this point
Copy the full SHA 74ac3a5View commit details
Commits on Aug 2, 2020
-
Agis Daniels edit be sure to remove these two lines and set them to 0 in the __init__ function to my understanding those are class variables shared by all instances of the class as stated in this link https://docs.python.org/3/tutorial/classes.html#class-and-instance-variables
projectPythonator authoredAug 2, 2020 Configuration menu - View commit details
-
Copy full SHA for bd78be6 - Browse repository at this point
Copy the full SHA bd78be6View commit details -
Merge pull request #3 from projectPythonator/AgisDaniels
removed two lines
projectPythonator authoredAug 2, 2020 Configuration menu - View commit details
-
Copy full SHA for 23b60fd - Browse repository at this point
Copy the full SHA 23b60fdView commit details
Commits on Aug 13, 2020
-
I coded up the rest of the functions while trying to stay true to the source code from c++ i ran into some bugs for CH_Graham scan which i need help understanding
projectPythonator authoredAug 13, 2020 Configuration menu - View commit details
-
Copy full SHA for 4c262ca - Browse repository at this point
Copy the full SHA 4c262caView commit details -
projectPythonator authored
Aug 13, 2020 Configuration menu - View commit details
-
Copy full SHA for 668d24c - Browse repository at this point
Copy the full SHA 668d24cView commit details -
Merge pull request #4 from projectPythonator/AgisDaniels
Agis daniels
projectPythonator authoredAug 13, 2020 Configuration menu - View commit details
-
Copy full SHA for bf15dc1 - Browse repository at this point
Copy the full SHA bf15dc1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.