Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List contributors the same as govuk-react #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gavinorland
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         188    188           
  Branches       43     43           
=====================================
  Hits          188    188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22a38d...e9ad016. Read the comment docs.

@gavinorland gavinorland requested review from stevesims and SimonMooreCIC and removed request for taranchauhan September 4, 2018 10:52
@penx
Copy link
Collaborator

penx commented Oct 5, 2018

I'm not a contributor to this project, @stevesims just plagiarised my work

@penx
Copy link
Collaborator

penx commented Oct 5, 2018

@stevesims reminded I am from when it was a different project

@penx
Copy link
Collaborator

penx commented Oct 5, 2018

contributors list in govuk-react was intended to be from either most contributions first or date order, it just happened to be alphabetical.

Don't really mind too much but I think me/Mark are main contributors on govuk-react and Steve/Toby/Gavin/Taz are main contributors here

@penx
Copy link
Collaborator

penx commented Oct 5, 2018

Approved unless anyone wants to discuss the above. Could use all-contributors or similar.

@gavinorland
Copy link
Collaborator Author

Yes, I originally thought maybe these should be ordered by number of contributions, but in the end we went with alphabetical. Since no comments, I'll merge! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants