-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if ignore_directives=False
but ignore_comments=True
#2840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2840 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 359 359
Lines 50258 50264 +6
=======================================
+ Hits 50202 50208 +6
Misses 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tidying this up Joe. Just a couple of small things to fix up. I'll run the integration tests in the meantime (although they should be unaffected).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks very much.
Will just have to wait on the integration tests so will be about an hour.
Okay great. Thanks for the review @arporter! |
The integration tests were (eventually) all green. |
Closes #2839.