#84 Add warm up iterations to NemoLite2D timing #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergisiso
force-pushed
the
84_add_warmup_timing
branch
from
dc083b1 to
e1a7e93
Compare
|
@arporter @rupertford This is not ready yet but I realised that changing nemolite2d.f90 is quite tedious because the file is replicated in all manual_implementations and in psykal. And it is important for fair comparison to have them all be equivalent. So I was thinking to do the same we do with namelist and create a original one and then the other be symbolic links to it. I am wondering where this original should be placed. Could you comment if you prefer:
|
|
I think having just one file is good and I'd prefer putting it in |
|
@sergisiso is this one ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiple timing sections in the nemolite2D algorithm layer. One of them for warm up time-stepping iterations so device initalisation done in the first iteration don't contribute to the average iteration time.
Also adds HIP backend for kokkos and fixes some issues.