Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit chatops setup values #250

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

khalford
Copy link
Member

@khalford khalford commented Dec 18, 2024

Description:

Editing setup values from original PR to setup apps. The values paths were not changes from worker to cloud-chatops cluster.
Also, adding set up values for argocd domain to access the UI


Submitter:

Have you:

  • Labelled this PR, e.g. bug, deployment, enhancement ...etc.
  • A deployment can be reviewed, and merged, by a single reviewer.
  • It can only be used to deploy, change, or remove clusters based on existing patterns for staging.
  • Anything involving prod, or production facing services must use the normal 2 person review.
  • All other PR types require the usual PR process (e.g. 2 person).

Reviewer

Have you:

  • Verified this PR uses the correct label(s) based on the rules above?
  • Checked if this could affect production (e.g. a global value that's changed without an override)?
  • Tested setting this up, if it's not a deployment, to verify it can be redeployed with any documentation if appropriate?

@khalford khalford added the bug Something isn't working label Dec 18, 2024
@khalford khalford self-assigned this Dec 18, 2024
Moving to feature branch so I can make changes without needing a PR each time
@khalford khalford marked this pull request as ready for review January 6, 2025 12:01
@anish-mudaraddi anish-mudaraddi merged commit 2c0fbab into main Jan 6, 2025
2 checks passed
@anish-mudaraddi anish-mudaraddi deleted the edit-chatops-setup-values branch January 6, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants