-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New implementation. #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm assuming subsequent PRs to update the readme.
Do we want a macro to query the configuration?
#if !ADOBE_CONTRACT_CONFIGURATION(unsafe)
int _uncaught_count = std::uncaught_exceptions();
#endif
...
// INTERNAL_ADOBE_CONTRACT_VIOLATION_BEHAVIOR is not a function-style | ||
// macro because it lets us give a better diagnostic on | ||
// misconfiguration. | ||
#ifndef ADOBE_CONTRACT_VIOLATION// Default is verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#ifndef ADOBE_CONTRACT_VIOLATION// Default is verbose | |
#ifndef ADOBE_CONTRACT_VIOLATION // Default is verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do that, but clang-format will put it back to the way it is. If you want to change that you need to update the formatting file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay - I'll look at updating the format file (the current one is horrible).
You tell me! Do you have a use-case? |
The primary use case is building additional facilities either on top of the current ones or alongside. Yes. We want to be able to query. |
Can you open an issue? Definitely a separable feature and I'd like to land a v0.9 |
@fosterbrereton Did you really mean to delete this branch and close my PR? |
Tests need updating: - ensure that ADOBE_CONTRACT_VIOLATION=minimal doesn't cause verbose output - ensure that misconfiguration produces a good message
We want to leave room for a trapping truly minimal implementation for those who don't need emergency shutdown measures.
4f6efea
to
386bdec
Compare
Tests need updating: