Reworking reduction #551
Merged
Reworking reduction #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked reduction to connect cancelation to the secondary task (it was detached in the prior version). As a side benefit, I eliminated double type erasure on all packaged tasks, reducing the invocation overhead and eliminating a heap allocation for large tasks. To-do before moving from draft PR - write unit tests to check cancelation points work correctly.
FelixPetriconi
approved these changes
Nov 25, 2024
| @@ -180,44 +180,44 @@ namespace detail { | |||
|
|
|||
| /**************************************************************************************************/ | |||
|
|
|||
| template <typename> | |||
| template <class> | |||
There was a problem hiding this comment.
Is there a specific reason that you changed the specifier to class?
There was a problem hiding this comment.
That was always the convention on stlab to match the standard usage. I'm not sure when it changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked reduction to connect cancelation to the secondary task (it was detached in the prior version). As a side benefit, I eliminated double type erasure on all packaged tasks, reducing the invocation overhead and eliminating a heap allocation for large tasks.
To-do before moving from draft PR - write unit tests to check cancelation points work correctly.