Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:'clean_session' in app.config is not passed to the client #142

Merged
merged 2 commits into from
Nov 18, 2023
Merged

fix:'clean_session' in app.config is not passed to the client #142

merged 2 commits into from
Nov 18, 2023

Conversation

congzhou09
Copy link
Contributor

"app.config['MQTT_CLEAN_SESSION'] = False" does not work currently. The reason is that the param is not passed to "self.client".

The git commit log shows this issue appeared since the commit hashed by "df8fcaae08dd43eb4fd8850f8380e8f8415a00b9".

@Sohaib90
Copy link
Collaborator

Sohaib90 commented Oct 1, 2023

Hey @congzhou09

Thank you for the PR. Yes I can see where the problem is. Would be nice if you could also edit the test cases to include a test case so that the PR is more complete. What do you think?

@congzhou09
Copy link
Contributor Author

Hey @congzhou09

Thank you for the PR. Yes I can see where the problem is. Would be nice if you could also edit the test cases to include a test case so that the PR is more complete. What do you think?

Roger that.

… 'False' instead of the default value 'True'
@congzhou09
Copy link
Contributor Author

Hello @Sohaib90 . I notice that the test case for MQTT_CLEAN_SESSION already exists in "tests/test_flaskmqtt.py:66". However, since the assertion value(True) is the same as the field's default value(True), it didn't detect the issue. So I have modified the assertion value to False.

@congzhou09
Copy link
Contributor Author

Hello @Sohaib90 . Are there any revise needed for this PR?

@Sohaib90
Copy link
Collaborator

@congzhou09 I see that the checks have passed, let me go through the PR in detail during this weekend and then I will merge it if no further issues are found :)

@Sohaib90 Sohaib90 merged commit 7db7b55 into stlehmann:master Nov 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants