Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ACM-9339] Added cluster_mgmt api to discovery controller" #200

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dislbenn
Copy link
Contributor

@dislbenn dislbenn commented Feb 2, 2024

Reverts #199

Copy link

openshift-ci bot commented Feb 2, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the approved PR approval has been given label Feb 2, 2024
@stolostron stolostron deleted a comment from openshift-ci bot Feb 2, 2024
@dislbenn
Copy link
Contributor Author

dislbenn commented Feb 2, 2024

/override dco

Copy link

openshift-ci bot commented Feb 2, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: dco

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dislbenn
Copy link
Contributor Author

dislbenn commented Feb 2, 2024

/cc @cameronmwall @ngraham20

Copy link

sonarqubecloud bot commented Feb 2, 2024

@cameronmwall
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stolostron stolostron deleted a comment from openshift-ci bot Feb 2, 2024
@dislbenn
Copy link
Contributor Author

dislbenn commented Feb 2, 2024

/override "KinD tests (1.20, latest)"

Copy link

openshift-ci bot commented Feb 2, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: KinD tests (1.20, latest)

In response to this:

/override "KinD tests (1.20, latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6c44b97 into main Feb 2, 2024
8 of 9 checks passed
@dislbenn dislbenn deleted the revert-199-add-cluster-mgmt-api branch February 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants