Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing parameters needed by konflux #243

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

gparvin
Copy link
Contributor

@gparvin gparvin commented May 30, 2024

@gparvin
Copy link
Contributor Author

gparvin commented May 30, 2024

/retest

@gparvin gparvin changed the title [WIP] Fix the missing parameters needed by konflux Fix the missing parameters needed by konflux May 31, 2024
@gparvin
Copy link
Contributor Author

gparvin commented May 31, 2024

/cc @dislbenn
The fix was to run a script Dale wrote that adds the IMAGE_URL and IMAGE_DIGEST to the deprecated-base-image-check. It piped it all through yq so there's a lot of reformatting. Any idea if more is needed?

@openshift-ci openshift-ci bot requested a review from dislbenn May 31, 2024 20:28
@dislbenn
Copy link
Contributor

dislbenn commented Jun 3, 2024

/lgtm

Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR approval has been given label Jun 3, 2024
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dislbenn
Copy link
Contributor

dislbenn commented Jun 3, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 8e7f748 into stolostron:main Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given dco-signoff: yes lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants