Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cve #543

Merged
merged 2 commits into from
Jan 8, 2025
Merged

update cve #543

merged 2 commits into from
Jan 8, 2025

Conversation

cameronmwall
Copy link
Contributor

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

If applicable, please reference the issue(s) that this pull request addresses.

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Cameron Wall <[email protected]>
@openshift-ci openshift-ci bot requested review from dislbenn and kurwang January 2, 2025 21:12
@openshift-ci openshift-ci bot added the approved PR approval has been given label Jan 2, 2025
@gparvin
Copy link
Contributor

gparvin commented Jan 8, 2025

@cameronmwall Can you run go mod tidy and then check in the updated go.mod and go.sum files? That should fix this. Thanks!

Signed-off-by: Cameron Wall <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jan 8, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2025
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,gparvin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Jan 8, 2025

@openshift-merge-bot openshift-merge-bot bot merged commit 3d2259e into stolostron:main Jan 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approval has been given dco-signoff: yes lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants