fix(w3up-client): authorize agent to use space

[fforbeck]

We need to save the space before setting it as the current space, otherwise the authorization flow will fail because the agent won't be allowed to use that space.

[alanshaw]

I don't think this is the right place for this. This needs to be done in createSpace, before authorizeContentServe is called.

However I don't really understand why it was not already saved as part of provisioning?

[fforbeck]

I don't think this is the right place for this. This needs to be done in createSpace, before authorizeContentServe is called.

However I don't really understand why it was not already saved as part of provisioning?

The provisioning only happens if the user passes the account which is optional. That's why it is not saved (just caught this case while testing the create space in the Console App).
Makes sense, I will move it to the createSpace function before the authorizeContentServe.

[alanshaw]

I guess my question is more, why is the console creating ephemeral spaces - not passing account?

[fforbeck]

I guess my question is more, why is the console creating ephemeral spaces - not passing account?

Got it. That happens because the Console implements the provisioning & recovery logic on the client side, we didn't have this provisioning logic on the w3up-client before. Now that we have it we could update the Console. I have a ticket to tackle this: storacha/project-tracking#237, but it will require some additional changes in the createSpace to pass the provider. I won't include that in this PR.