fix(egress/record): Remove unnecessary multiplication for ts conversion #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storacha#1588) ### Context This PR fixes the handling of the `servedAt` timestamp in the `packages/upload-api/src/space/record.js` file. The previous implementation included a multiplication by 1000, assuming a conversion from seconds to milliseconds was necessary. This change removes the conversion.
fforbeck
changed the title
alanshaw
approved these changes
Dec 12, 2024
fforbeck
changed the base branch from
feat/create-space-content-serve
to
main
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.8](upload-api-v1.1.7...upload-api-v1.1.8) (2024-12-12) ### Fixes * **egress/record:** Remove unnecessary multiplication for ts conversion ([#98](#98)) ([79ac1ab](79ac1ab)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) * **egressRecord:** Remove unnecessary multiplication for ts conversion ([storacha#1588](https://github.com/storacha/upload-service/issues/1588)) ([1870202](1870202)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes the handling of the
servedAttimestamp in thepackages/upload-api/src/space/record.jsfile.The previous implementation included a multiplication by 1000, assuming
a conversion from seconds to milliseconds was necessary. This change
removes the conversion.