Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delegation revoke command #106

Merged
merged 10 commits into from
Oct 20, 2023
Merged

feat: add delegation revoke command #106

merged 10 commits into from
Oct 20, 2023

Conversation

travis
Copy link
Member

@travis travis commented Oct 17, 2023

Adds w3 delegation revoke to enable users to revoke delegations they have issued.

needs new versions of access-client and w3up-client from this PR to build cleanly:

storacha/w3up#975
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a few non-blocking tweaks to error messages.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/bin.spec.js Outdated Show resolved Hide resolved
@alanshaw
Copy link
Member

alanshaw commented Oct 18, 2023

Oh, please can you add to the ToC in the README 🙏: https://github.com/web3-storage/w3cli#commands

@travis travis changed the title wip: initial work toward revoke command feak: add delegation revoke command Oct 19, 2023
@travis travis changed the title feak: add delegation revoke command feat: add delegation revoke command Oct 19, 2023
this brings in more capabilities on auth
@travis travis merged commit 3c8f3bc into main Oct 20, 2023
1 check passed
@travis travis deleted the feat/revocations branch October 20, 2023 21:30
travis pushed a commit that referenced this pull request Oct 20, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.5.0](v4.4.0...v4.5.0)
(2023-10-20)


### Features

* add `delegation revoke` command
([#106](#106))
([3c8f3bc](3c8f3bc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants