Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: space usage reports #120

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat: space usage reports #120

merged 2 commits into from
Nov 13, 2023

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Nov 9, 2023

Adds space usage report by fetching accounts and then getting reports for each space owned by accounts.

Screenshot 2023-11-13 at 17 32 50

@alanshaw alanshaw marked this pull request as ready for review November 13, 2023 14:34
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✨

Comment on lines +488 to +491
const period = {
// we may not have done a snapshot for this month _yet_, so get report from last month -> now
from: startOfLastMonth(now),
to: now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log the period we are tracking?

Copy link
Member Author

@alanshaw alanshaw Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's a report as of now.

If we were graphing the data then yes but we are not doing that here in the CLI :)

@alanshaw alanshaw merged commit 5587a0d into main Nov 13, 2023
1 check passed
@alanshaw alanshaw deleted the feat/usage-report branch November 13, 2023 14:47
Gozala pushed a commit that referenced this pull request Nov 14, 2023
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](v4.6.0...v5.0.0)
(2023-11-14)


### ⚠ BREAKING CHANGES

* wait for the plan picker
([#124](#124))
* new authorization flow
([#121](#121))

### Features

* new authorization flow
([#121](#121))
([8d7caf6](8d7caf6))
* setup prettier + linter
([#116](#116))
([5707e54](5707e54))
* space usage reports
([#120](#120))
([5587a0d](5587a0d))
* switch tests to using upload-api
([#118](#118))
([be19ff9](be19ff9))
* wait for the plan picker
([#124](#124))
([dff71c4](dff71c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants