feat: upgrade deps for blob #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
commented
Jun 3, 2024
test/bin.spec.js
Outdated
|
|
||
| 'w3 login': test(async (assert, context) => { | ||
| const login = w3 | ||
| .args(['login', '[email protected]']) | ||
| .args(['login', 'alice-cli-test@web.mail']) |
There was a problem hiding this comment.
looks like [email protected] is flagged as spam email and we cannot use it anymore? I get an error
| @@ -81,7 +81,7 @@ bafybeibvbxjeodaa6hdqlgbwmv4qzdp3bxnwdoukay4dpl7aemkiwc2eje` | |||
| 'uploadListResponseToString can return the upload roots as newline delimited JSON': | |||
| (assert) => { | |||
| assert.equal( | |||
| uploadListResponseToString(uploadListResponse, { shards: true }), | |||
| uploadListResponseToString(uploadListResponse, { shards: true, plainTree: true }), | |||
There was a problem hiding this comment.
looks like some color changes that made this now fail unless I do this?
vasco-santos
commented
Jun 3, 2024
test/bin.spec.js
Outdated
| .env(context.env.alice) | ||
| .args(['account ls']) | ||
| .join() | ||
| // 'w3 account ls': test(async (assert, context) => { |
There was a problem hiding this comment.
somehow this does ls on my account 🤷🏼♂️
alanshaw
approved these changes
Jun 3, 2024
vasco-santos
commented
Jun 3, 2024
added 2 commits
June 3, 2024 17:18
vasco-santos
commented
Jun 3, 2024
README.md
Outdated
| # delegate store/* and upload/* to did:key:z6M..., output as a string | ||
| w3 delegation create did:key:z6M... --can 'store/*' --can 'upload/*' --base64 | ||
| # delegate all space admin capabilities to did:key:z6M..., output as a string | ||
| w3 delegation create did:key:z6M... --can 'space/*' --base64 |
There was a problem hiding this comment.
should we filecoin/offer? 😬
There was a problem hiding this comment.
or I mean, upload/ should also maybe keep there?
vasco-santos
pushed a commit
that referenced
this pull request
Jun 4, 2024
🤖 I have created a release *beep* *boop* --- ## [7.7.0](v7.6.2...v7.7.0) (2024-06-04) ### Features * allow pipe to w3 up ([#188](#188)) ([4961f4a](4961f4a)) * upgrade deps for blob ([#187](#187)) ([7f52cc0](7f52cc0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds blob add, ls and rm commands.