feat: implement uploadCAR in uploader
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis
approved these changes
May 17, 2023
| issuer: agent, | ||
| with: space.did(), | ||
| audience: servicePrincipal, | ||
| proofs: await getProofs([ |
There was a problem hiding this comment.
If I recall correctly you don't actually need to include these proofs manually - access-client should look through its list of proofs and include relevant proofs automatically. Could be misremembering so worth testing....
There was a problem hiding this comment.
Hmm, I thought that was w3up-client? Remember we're using upload-client here...
There was a problem hiding this comment.
oh right - what I'm thinking of is actually in agent.js in access-client which is I think what getProofs ends up calling into - what you've got is exactly right!
this is probably another argument in favor of refactoring this to use w3up-client rather than using the upload and access clients separately...
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This was referenced May 17, 2023
travis
pushed a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](uploader-core-v5.1.0...uploader-core-v5.2.0) (2023-05-19) ### Features * implement `uploadCAR` in uploader ([#517](#517)) ([40036ea](40036ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
pushed a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](react-uploader-v4.1.0...react-uploader-v4.2.0) (2023-06-20) ### Features * implement `uploadCAR` in uploader ([#517](#517)) ([40036ea](40036ea)) ### Bug Fixes * missing `dataCID` in `onUploadComplete` callback ([#525](#525)) ([fb048a9](fb048a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
added a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](solid-uploader-v4.1.0...solid-uploader-v4.2.0) (2023-06-20) ### Features * implement `uploadCAR` in uploader ([#517](#517)) ([40036ea](40036ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](vue-uploader-v4.1.0...vue-uploader-v4.2.0) (2023-06-20) ### Features * implement `uploadCAR` in uploader ([#517](#517)) ([40036ea](40036ea)) ### Bug Fixes * inferred type error ([#516](#516)) ([1bf4cf2](1bf4cf2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the
upload-client'suploadCARfunction in theUploaderProvider.I need to be able to access this to upload merkle clock events generated by bucket mutations to w3up.