avoid background goroutine #9

egonelbre · 2022-10-03T15:38:35Z

No description provided.

jtolio

okay i see, instead of having a long-running processing goroutine, this spawns one per message? the code certainly seems simpler, though i worry this is less efficient

jtolio · 2022-10-03T15:41:51Z

client.go

+		c.pending = c.newOutgoingPacket()
+		c.flush = make(chan struct{}, 1)
+		c.active.Add(1)
+		go c.waitForFull(c.pending, c.flush)


background goroutine?

Yeah, sorry, for not being clear -- a long running background goroutine.

egonelbre · 2022-10-03T16:00:24Z

@jtolio with regards to efficiency, it can implement a coalescing queue -- so you'll have a worker only for the time when you are actually sending stuff out.

However, indeed, I'm not quite sure whether this is better in general or not.

avoid background goroutine

7c979db

egonelbre force-pushed the ee/nojitter branch from a620147 to 7c979db Compare October 3, 2022 15:42

jtolio reviewed Oct 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

avoid background goroutine #9

avoid background goroutine #9

egonelbre commented Oct 3, 2022

jtolio left a comment

jtolio Oct 3, 2022

egonelbre Oct 3, 2022

egonelbre commented Oct 3, 2022 •

edited

Loading

avoid background goroutine #9

Are you sure you want to change the base?

avoid background goroutine #9

Conversation

egonelbre commented Oct 3, 2022

jtolio left a comment

Choose a reason for hiding this comment

jtolio Oct 3, 2022

Choose a reason for hiding this comment

egonelbre Oct 3, 2022

Choose a reason for hiding this comment

egonelbre commented Oct 3, 2022 • edited Loading

egonelbre commented Oct 3, 2022 •

edited

Loading