Add composer.json #20
Conversation
|
I'll discuss this here with the team - i'm a bit hesitant to add a composer file as it's a wordpress plugin and would require more configuration to work with the wordpress structure than people would usually expect with composer - depending on where you're storing your composer.json. Is it better to leave this to WordPress packages? http://wpackagist.org |
|
http://wpackagist.org is awesome for WordPress plugins if they are in the official wordpress.org repository. Given this plugin is not in the wordpress.org repository it isn't in the wpackagist repository. This issue would also be solved if you would deploy to the wordpress.org repository. If you want I can make a pull request using grunt-wp-deploy to deploy to wordpress.org. I thought because this is a developer focused plugin that adding a composer.json and adding it to packagist would be the correct path. |
|
+1 with the argumentation of @atimmer ! Thanks, |
|
+1 me too ! It's just one file composer.json that would be very nice. Thanks. |
|
+1 I just sent in a pull request for the same thing! Closed my duplicate version. |
|
+1 |
6 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
Is there any chance you will be doing this anytime soon? It's a pain in the ass to have:
as oppossed to:
|
|
Fork it and use ur fork. Even can add it to packagist tho i think it's against their terms technically.
…Sent from my mobile phone
On Mar 23, 2017, at 4:38 PM, Danny van Holten ***@***.***> wrote:
Is there any chance you will be doing this anytime soon? It's a pain in the ass to have:
{ "type": "package", "package": { "name": "acf-gravityforms", "version": "dev-master", "type": "wordpress-plugin", "dist": { "type": "zip", "url": "https://github.com/stormuk/Gravity-Forms-ACF-Field/archive/master.zip" } } }
as oppossed to:
"wpackagist-plugin\gravityforms-acf-field","*"
or
"stormuk\gravityforms-acf-field","*"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Agreed, but I prefer the proper way and not use my fork. If this is not getting any reactions I feel obliged to as well though. |
|
In most cases, a fork does not really help as you still need to update it manually as opposed to getting updates rolled out by Gravity as soon as they are ready. |
Not a problem in this case, considering this repo hasn't been updated in 2 years. |
|
Did so. I also went trough the other pull requests and basically started all over again. I also submitted it to the WP plugin directory so everyone can safely use it. P.S: I did a few changes why it isn't compatible with this version. Basically it's because I renamed the field from acf_field_gravityforms to forms, so you should check your website when changing it.. |
|
Given that your 'new' plugin is based entirely on this code, I think it would have been better for you to fork this repo, keep the history, and make your changes on top. If you're wanting to take this over, we would happily add a message pointing people to your fork. What you've done is take this code, and remove the MIT licence it was released under (DannyvanHolten/acf-gravityforms-add-on@eb095b0). Please can you at the very least re-add that, and perhaps even leave in a reference to the original authors, who still deserve credit even if they've since moved onto other projects. |
|
As @atimmer point out releasing this under an MIT License is not allowed. It should be GPL v2+ in the first place as it is a wordpress plug-in.
|
|
You can't make your new repo a fork of this one retroactively, you would need to remove it and start again, should you wish to. To be honest, I'm not familiar with WordPress or the intricacies of licensing for code that runs within it. All I'm saying is that it would be right and proper for you to ensure your code (which is an edit of this code, which was itself based on someone else's code) properly credits those who came before. See the bottom of our README.md for an example. |
|
Thanx, I will :) I will do that somewhere this week. |
|
Have credited you (a while ago, but forgot to mention it here). :) |
With this composer.json the package can be used using composer. Preferably you would also add the package to packagist.
License is GPL automatically because WordPress has a GPL license.