fix: apostrophe-issue-richtext #1314
Open
+145
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new utility function `decodeHtmlEntities` to decode HTML entities in strings. - Updated `convertAttributesInElement` to handle string children by decoding HTML entities before processing. - Enhanced the handling of text nodes to ensure proper rendering of HTML content in React elements.
alvarosabu
added
bugfix
commit: |
edodusi
requested changes
Jan 10, 2025
| import React from 'react'; | ||
| import { BrowserRouter, Link, Route, Routes } from 'react-router'; |
There was a problem hiding this comment.
I'm not sure we want to make our React playground dependent on react-router honestly, is this needed?
| @@ -11,7 +11,7 @@ import { apiPlugin, storyblokInit } from '@storyblok/react'; | |||
| import IFrameEmbed from './components/iframe-embed'; | |||
|
|
|||
| storyblokInit({ | |||
| accessToken: 'd6IKUtAUDiKyAhpJtrLFcwtt', | |||
| accessToken: 'OurklwV5XsDJTIE1NJaD2wtt', | |||
There was a problem hiding this comment.
I think we need to document which space is associated with these demo token, or it would be a mess to test them later
| @@ -1,5 +1,11 @@ | |||
| import React from 'react'; | |||
|
|
|||
| function decodeHtmlEntities(text: string): string { | |||
| const textarea = document.createElement('textarea'); | |||
There was a problem hiding this comment.
this would break in SSR because of the use of document on the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeHtmlEntitiesto decode HTML entities in strings.convertAttributesInElementto handle string children by decoding HTML entities before processing.