Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiamondIcon color #24

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix DiamondIcon color #24

merged 1 commit into from
Feb 1, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Feb 1, 2024

📦 Published PR as canary version: 1.2.4--canary.24.9a9ed31.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@cdedreuille
Copy link
Contributor

Is this fix fixed using the generator? If not we should fix this in Figma first before doing anything.

@ghengeveld
Copy link
Member Author

I fixed the code directly, not through Figma.

@cdedreuille
Copy link
Contributor

I fixed the bug in Figma and tested to generate the icon again. It worked as intended so we're good to go.

@cdedreuille cdedreuille merged commit 875b984 into main Feb 1, 2024
7 checks passed
@cdedreuille cdedreuille deleted the fix-diamond-icon-color branch February 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants