Upgrade react-element-to-jsx-string dependency of app/react
#17076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 43ef8b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
angry-meow
changed the title
react-element-to-jsx-string dependencyreact-element-to-jsx-string dependency of addons/docs
|
@angry-meow could you investigate "react-element-to-jsx-string" version 15 that seems o have been released 2 months ago? Does this (I hope so) solve both problems? Thank you for the help! |
# Conflicts: # addons/docs/package.json # yarn.lock
ndelangen
changed the title
react-element-to-jsx-string dependency of addons/docsreact-element-to-jsx-string dependency of app/react
ndelangen
approved these changes
Jun 30, 2022
3 tasks
|
Hi, what's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16827 but unfortunately reopens #12747.
react-element-to-jsx-stringwas updated in #16407 as a bug fix.But #16827 seems to be a more common problem.
What I did
I edited
addons/docs/package.jsonthen ranyarn.I didn't commit these changes:
lib/core-server/src/__snapshots__/cra-ts-essentials_manager-prod-windowslib/core-server/src/__snapshots__/cra-ts-essentials_preview-prod-windowsThere were the following addition the the existing
prodsnapshots: