-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y: Create a toolbar button that allows users to disable/enable interaction #29018
base: next
Are you sure you want to change the base?
A11y: Create a toolbar button that allows users to disable/enable interaction #29018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings
code/core/src/preview-api/modules/preview-web/render/StoryRender.ts
Outdated
Show resolved
Hide resolved
code/core/src/preview-api/modules/preview-web/render/StoryRender.ts
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef5294e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Hi @JReinhold, I'm hoping to get this accessibility feature into Storybook, as the motion of Interactions has been problematic for some team members. We love using Interactions but need a way to disable them on page load for users with reduced motion preferences. Is there anything I can do to help move this PR forward? Thanks in advance! |
@shilman so sorry to keep being noisy... I am really eager to get an accessibility fix out for this feature 🙏 ! |
Relates to:
What I did
In order to improve accessibility on storybook I added a toggle in the toolbar to disable/enable interactions. This will allow users to navigate through the stories without triggering any interactions that could cause motion issues.
I save user preferences in localStorage so that the setting is remembered between sessions.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
disable interaction
toolbar button is correctly rendered and by default interactions playdisable interaction
toolbar button and check that interactions do not play as you navigate throughout storybookenable interaction
toolbar button again and check that interactions do play as you navigate throughout storybookDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR introduces a new feature to Storybook that allows users to disable/enable interactions, improving accessibility by preventing unwanted motion. Here's a summary of the key changes:
InteractionToggle
component incode/addons/interactions/src/components/InteractionToggle.tsx
code/addons/interactions/src/manager.tsx
to integrate the new toggle into the Storybook UIcode/core/src/preview-api/modules/preview-web/render/StoryRender.ts
to respect the interaction toggle stateKey points: