Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrypt: Increase log_n until it is measurable #424

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

str4d
Copy link
Owner

@str4d str4d commented Dec 17, 2023

Closes #418.

@str4d str4d added this to the rage 0.10.0 milestone Dec 17, 2023
@str4d
Copy link
Owner Author

str4d commented Dec 17, 2023

@Rileran could you test this and check that it resolves your issue?

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed12d5f) 41.56% compared to head (967750c) 41.51%.
Report is 2 commits behind head on main.

Files Patch % Lines
age/src/scrypt.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   41.56%   41.51%   -0.06%     
==========================================
  Files          34       34              
  Lines        3214     3218       +4     
==========================================
  Hits         1336     1336              
- Misses       1878     1882       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rileran
Copy link

Rileran commented Dec 18, 2023

Works great, thanks for the quick fix !

@str4d str4d merged commit 0a64d38 into main Dec 27, 2023
34 of 37 checks passed
@str4d str4d deleted the 418-scrypt-very-fast-machines branch December 27, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid scrypt work factor calculation on system with bad SystemTime precision
2 participants