age: Don't exit peeking state if entire identity file fits in the buffer #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, a single line and no trailing newline.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
+ Coverage 50.57% 50.64% +0.07%
==========================================
Files 42 42
Lines 4117 4121 +4
==========================================
+ Hits 2082 2087 +5
+ Misses 2035 2034 -1 ☔ View full report in Codecov by Sentry. |
This ensures we can call `PeekableReader::reset` when the file is a single line without a trailing newline character, which rage-keygen does not generate but users can. Closes #484.
str4d
force-pushed
the
484-identity-file-newline-fix
branch
from
548ee65
to
5a57e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we can call
PeekableReader::resetwhen the file is a single line without a trailing newline character, which rage-keygen does not generate but users can.Closes #484.