Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RawIterator generic #71

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

straight-shoota
Copy link
Owner

This is a workaround for a Crystal compiler bug (crystal-lang/crystal#14317).
But it might also be benefitial on its own (#70 (comment)) so I'm not leaving a note to eventually revert this.

RawIterator is an undocumented internal type, so this change should be fine with regards to backwards compatibility.

Resolves #70

@straight-shoota straight-shoota self-assigned this Feb 25, 2024
@straight-shoota straight-shoota merged commit bc1c534 into master Mar 10, 2024
15 of 17 checks passed
@straight-shoota straight-shoota deleted the chore/workaround-raw_iterator branch March 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscompile on Object that produces an Iterator
1 participant